From 17a6c03701bf65c0b4e8b5ed5a3970cd0248c47f Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Fri, 17 Jan 2020 17:38:19 +0100 Subject: [PATCH] build: fix dependency file generation with ENFORCE_UNIQUE_SYMBOLS=y The recorded file, unless overridden by -MQ (or -MT) is that specified by -o, which doesn't produce correct dependencies and hence will cause failure to re-build when included files change. Fixes: 81ecb38b83b0 ("build: provide option to disambiguate symbol names") Reported-by: Andrew Cooper Signed-off-by: Jan Beulich Tested-by: Andrew Cooper Acked-by: Andrew Cooper --- xen/Rules.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/Rules.mk b/xen/Rules.mk index 5aba841b0a..2f4e6f3d96 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -195,7 +195,7 @@ SRCPATH := $(patsubst $(BASEDIR)/%,%,$(CURDIR)) %.o: %.c Makefile ifeq ($(CONFIG_ENFORCE_UNIQUE_SYMBOLS),y) - $(CC) $(CFLAGS) -c $< -o $(@D)/.$(@F).tmp + $(CC) $(CFLAGS) -c $< -o $(@D)/.$(@F).tmp -MQ $@ ifeq ($(clang),y) $(OBJCOPY) --redefine-sym $<=$(SRCPATH)/$< $(@D)/.$(@F).tmp $@ else -- 2.30.2